Template talk:Fornminne

This template is broken: Lämningsnummer. Det är lämningens identitet och består av L samt årtal och ett löpnummer, till exempel L2017:5013. With new numbers, that begin on L it does not work. Macuser (talk) 19:55, 23 March 2020 (UTC)

@Lokal Profil, Abbe98, and Vogler: We need to support new IDs as well. How is that best solved? Ainali (talk) 16:59, 6 April 2020 (UTC)

Pretry sure there is a task for this but can't easily locate it now. Unless I'm misremembering the old ids still work, but newly designated places/objects only get the new id? Adding a new parameter for L-ids should be fairly simple, the issue comes with matching those ids to the old ones (for categorization) and figuring out how people can find the mew ids (last I checked they were not publically viewable, but that might have changed). /Lokal_Profil 19:15, 14 April 2020 (UTC)

They are visible, like L1944:4529. Macuser (talk) 20:15, 15 April 2020 (UTC)

The problem is the new L-id’s doesn’t seem connected to the http-link we need. Or do we need to convert the L-id into a binary number and add to the http-adress? --Vogler (talk) 05:02, 16 April 2020 (UTC)

The template has never been intended for L-numbers, soon I believe the new UUIDs will be available as kulturarvsdata-URIs and we could then maybe port the template to support both the old FMIS ID's and the new KMR ID's. Maybe @Biltvätt and Tulipasylvestris: knows when. Abbe98 (talk) 13:59, 19 April 2020 (UTC)

L1962:8692 converted to hexadecimal is 4c313936323a38363932. However that doesn’t match the hexadecimal part of the URL for L1962:8692 which is https://app.raa.se/open/fornsok/lamning/aeee5d3e-a3b2-4af7-82d1-f0fff570c752 --Vogler (talk) 15:13, 19 April 2020 (UTC)

@Vogler: who said anything about hexadecimal? The URL suffix is a UUID. --Abbe98 (talk) 17:53, 10 June 2020 (UTC)

@Lokal Profil and Ainali: I think this can be resolved now as the new UUIDs is resolvable in Kulturarvsdata as of today. I will take a stab at it soonish. --Abbe98 (talk) 17:53, 10 June 2020 (UTC)

Actually here is a draft solution based on the length of the id. That said it's not tested and I don't even have the rights to make the actual edit. --Abbe98 (talk) 18:27, 10 June 2020 (UTC)

Edit request to support new ID's

{{Edit request}} Please replace the content of this template with the following content. The reason is that Fornsök, which the template links to, has introduced another type of ID (UUID), and different URL is needed to resolve the new ID. This is done via checking how long the ID is. A discussion about it is here phab:T231334

Please simultaneously update Template:Fornminne/layout.

Thank you! --Alicia Fagerving (WMSE) (talk) 08:24, 10 September 2020 (UTC)

{{Autotranslate|base=Fornminne|1={{{1|}}}|2={{{RAÄ-nr|{{{2|}}}}}} }}<includeonly>{{#if:{{{1|}}}|{{#ifeq:{{NAMESPACE}}|File|{{{category|[[Category:Archaeological monuments in Sweden with known IDs|{{{1}}}]]}}}}}|[[Category:Archaeological monuments in Sweden without known IDs]]}} {{ifeq|{{#invoke:String|len|{{{1}}}}}|14 |{{WikidataCheck|property=P1260|prefix=raa/fmi/|value={{{1|}}}|category=Fornminne ID|namespaces=0,14}} |{{WikidataCheck|property=P1260|prefix=raa/lamning/|value={{{1|}}}|category=Fornminne ID|namespaces=0,14}}{{#ifeq:{{NAMESPACE}}|File|{{{category|[[Category:Archaeological monuments in Sweden with UUIDs|{{{1|}}}}}}}}]]}}}}} }} </includeonly><noinclude> {{documentation}} </noinclude>

 Done, with a few tweaks to the wikitext to reduce the amount of changes in the diff. Please check that it works! --Lucas Werkmeister (talk) 10:09, 10 September 2020 (UTC)

@Alicia Fagerving (WMSE) and Lucas Werkmeister: please be careful with these templates especially when Wiki Loves Monuments is running. In this edit you broke the categorization. Multichill (talk) 10:12, 10 September 2020 (UTC)

@Multichill: comments on T231334 suggest the removed padding was intentional (though I confess I haven’t read the whole task yet, just skimmed it). --Lucas Werkmeister (talk) 10:17, 10 September 2020 (UTC)

Not having a space for the sorting of Category:Archaeological monuments in Sweden with known IDs will completely change the way it's sorted. The sortkey won't be usable anymore and the categorization jobs will fail. Multichill (talk) 10:22, 10 September 2020 (UTC)

@Multichill: I don't believe the removed paddig should have affected the categorisation. All classic id's were already 14 digits and the newly supported UUIDs aren't known by the monuments database anyway (because the tables back on sv.wp use the classic ids). /Lokal_Profil 23:14, 4 January 2021 (UTC)

URL change

@Anton.haglund: , I reverted your change of the URL pattern in the template layout. RAÄs policy makes it clear that open.raa.se links are unstable while kulturarvsdata.se links are stable. This is also illustrated by the old FMIS identifiers still when kulturarvsdata.se is used. If you still think there is a reason for this change please bring it up to discussion here. Abbe98 (talk) 10:27, 2 February 2022 (UTC)

Tracking files with non-UUID identifiers

We have Category:Archaeological monuments in Sweden with UUIDs but given that most usages have now been migrated to UUIDs, a tracking category for usages of non-UUID identifiers (which are likely broken) would be even more useful.

Ping @Alicia Fagerving (WMSE), @Lokal Profil, @Multichill Abbe98 (talk) 05:45, 30 May 2023 (UTC)

@Abbe98, Alicia Fagerving (WMSE), and Lokal Profil: Looks like you all made a big mess out of it. I see edits like these where the old identifier is removed, but that old identifier seems to be the only way to find Q29580339 or in sv:Lista över fornlämningar i Mariestads kommun. What were you thinking? Why did you mix old and new identifiers in the same template in the same field? Why did you replace the old identifier?

The best next step would be to move this UUID identifier to a new field and to restore the old identifiers. Multichill (talk) 15:42, 30 May 2023 (UTC)

@Multichill Wikidata and the lists on sv.wp are essentially a stale and odd subset of monuments for Swedish WLM, anyone can go ahead and update these if they see a value in doing so. Reusing the same field saved the campaigns and upload tools at the time. A new parameter would have broken existing workflows, campaigns and re-usage. Abbe98 (talk) 17:18, 30 May 2023 (UTC)

So short-term gains gave long-term pains. Pointing to other people for the mess you created is not the nicest thing to do. I'm just going to remove this template from my watchlist and back away. Good luck to the Swedish community sorting this out. Multichill (talk) 17:37, 30 May 2023 (UTC)