User talk:CommonsDelinker/archive01

From Wikimedia Commons, the free media repository
Jump to navigation Jump to search

Kalu Pande.jpg[edit]

Please change the name of Portrait of Damodar Pande.jpg to Kalu Pande.jpg because the Portrait was incorrectly named as Damodar Pande while the Portrait is of real Kalu Pande. Airkeeper (talk) 18:05, 11 April 2017 (UTC)[reply]

Also the Portrait of "Bhim Shamsher Jang Bahadur Rana.jpg" is of real Chandra Shamsher JB Rana and vice versa. Please alter their names. If it can't be renamed, then help to delete it. Airkeeper (talk) 18:08, 11 April 2017 (UTC)[reply]

@Airkeeper: This is not the place to ask. See the message I left on your talk page. - Reventtalk 18:39, 11 April 2017 (UTC)[reply]

Common gallery bug?[edit]

Special:Diff/250124568/250125093 -- User: Perhelion 10:12, 3 July 2017 (UTC)[reply]

Removing xwiki user pages[edit]

Currently there are many user pages for this account, and most are soft redirects, and pre-date global user pages. As such user pages are less than useful, I have either directly deleted, or requested the removal of the User:CommonsDelinker. There are currently some customised local language versions, and they have been left undisturbed. The user page at m:User:CommonsDelinker will now show. We should also consider whether we should be looking to transclude.  — billinghurst sDrewth 11:03, 22 May 2018 (UTC)[reply]

There are still many user talk pages, and we should consider whether we wish for them to be deleted, or as redirects to here at Commons.

 — billinghurst sDrewth 10:51, 22 May 2018 (UTC)[reply]

Damage on Wikidata[edit]

Delinking deletes qualifiers. --Infovarius (talk) 17:49, 7 June 2018 (UTC)[reply]

Not only qualifiers: sources and ranks too. That is, it makes depreciated statements normal. This seems to be a serious issue: d:Special:Diff/1476825925/1481491800. – Máté (talk) 04:59, 16 August 2021 (UTC)[reply]

CommonsDelinker down?[edit]

Hi, Is the bot down? There are many requests waiting, and the last edit was on 06:30, 2 May 2019. Regards, Yann (talk) 02:52, 13 May 2019 (UTC)[reply]

Error[edit]

In this edit, it removed part of a useful link to the deletion discussion. In fact, why is it editing archives anyway? --- C&C (Coffeeandcrumbs) 10:23, 18 January 2020 (UTC)[reply]

Stopped removing commands[edit]

@Steinsplitter and Hoo man: Do you know why the bot has stopped removing completed commands from /commands ? Seems that it stopped on April 30.  — billinghurst sDrewth 01:32, 23 May 2020 (UTC)[reply]

Not to worry, something had it clagged. Back now after manual intervention.  — billinghurst sDrewth 01:58, 23 May 2020 (UTC)[reply]

Hung several days[edit]

Last action seems to be on May 28. DMacks (talk) 03:09, 2 June 2020 (UTC)[reply]

Resurrecting[edit]

Removal of deleted files, file move[edit]

It's been dead since 2020-11-04 01:57:08, I think I have found and fixed a bunch of bugs, may start working soon. There are a few pending requests (about 150 thousand), it may take a while. --grin ✎ 15:49, 1 March 2021 (UTC)[reply]

@Grin: Thank you for fixing the bugs. Highly appreciated :) --Steinsplitter (talk) 14:27, 6 March 2021 (UTC)[reply]
@Grin: Thanks for great work! When the bot is expected to start to move categories? --jdx Re: 09:22, 7 March 2021 (UTC)[reply]
@Jdx: I am not sure this code is the same as the category mover: there seem to be multiple "bots" using the CommonsDelinker user. I'll check the code for catmov a bit later, thanks for mentioning. --grin ✎ 12:58, 7 March 2021 (UTC)[reply]
@Steinsplitter: do you have any idea which bot moves (should move) the categories? It seems to be a different code than delinquent. I see a rmcatmoves.php but it looks like just a cleanup script after something have finished the move. --grin ✎ 15:04, 8 March 2021 (UTC)[reply]
@Grin: BTW, the "cleanup script" works as expected, i.e. when a request is in the queue and someone moves the category manually, then after some time the bot removes the request from the queue (I believe the cleanup script runs at 2AM and 2PM UTC). --jdx Re: 08:06, 10 March 2021 (UTC)[reply]
@Jdx: Unfortunately I can't help in the catmov problem, it seems to be a different bot. (I haven't touched the cleanup script either, so if it worked in the past it still shall work now.) --grin ✎ 14:24, 10 March 2021 (UTC)[reply]
Catmov topic has been moved down under a new subtitle. --grin ✎ 11:02, 12 April 2021 (UTC)[reply]
Looks like the file moves on User:CommonsDelinker/commands need to be changed as they're all been moved to a different title after the moves were requested so the replacements are all redirects and give a 'No such replacement file:' error --Nintendofan885T&Cs apply 11:38, 7 March 2021 (UTC)[reply]
@Nintendofan885: There were multiple problems starting the bot after 4 months, one of those is the "old" articles were sometimes changed in the meantime and the image was not there anymore. Also there were multiple connection problems (ranging from CSRF errors to hard mediawiki errors) and weird responses (like the bot logging in then get "you are banned since you're not logged in" errors). Right now the bot creates huge amount of logs, and since it have finished processing all the backlog I'll check the error codes (next week probably) and investigate whether "file not founds" were justified and proper or it's yet another bug in the code. Please keep reporting any problems you find and I'll try to check them one by one. --grin ✎ 12:58, 7 March 2021 (UTC)[reply]
Lot of failed changes are indeed on redirects and included templates, but it's not a "bug" in the bot, it just works this way. --grin ✎ 17:37, 7 March 2021 (UTC)[reply]

Category moves[edit]

Category moves are handled by a different robot code, moved here for better visibility --grin ✎ 11:02, 12 April 2021 (UTC)[reply]

@Zhuyifei1999: Would you please give a hint as to what part of the bot is supposed to do category moves on Commons?   — Jeff G. ツ please ping or talk to me 16:25, 4 April 2021 (UTC)[reply]

User:SteinsplitterBot --Zhuyifei1999 (talk) 06:59, 5 April 2021 (UTC)[reply]
The switch from python2 to python3 in pywikibot has broken a number of scripts, i fix them on sight. This one is fixed as well now and should work again :). @Grin: Thankf for fixing the delinker thing. Highly appricated :). I am atm very busy, sorry for that. Best --Steinsplitter (talk) 09:42, 5 April 2021 (UTC)[reply]
@Steinsplitter: we all do what we can. :-) Thanks to you (and also Zhuyifei1999) as well! --grin ✎ 11:02, 12 April 2021 (UTC)[reply]
Thank you all!   — Jeff G. ツ please ping or talk to me 11:12, 12 April 2021 (UTC)[reply]
@Steinsplitter: so if I understand correctly the catmoves are done by SteinsplitterBot, who is a pywikibot and is supposed to get the moves done? Or does it need more love to run first? --grin ✎ 16:47, 14 April 2021 (UTC)[reply]
Yes, it is pywikibot. Generally the script should work now, i fixed it a (few days ago?). Let me know if something is broken. --Steinsplitter (talk) 17:42, 14 April 2021 (UTC)[reply]
Something is not right. In some cases there is "(0 entries moved, 0 to go)", when there are some entries.VVerka5 (talk) 13:06, 18 June 2021 (UTC)[reply]

Incorrect replacements[edit]

In sv:Special:Diff/48973175 CommonsDelinker broke an image link by making the same replacement twice. In sv:Special:Diff/48958641 three images were replaced but two of the file names only partly matched the replaced file name, creating two broken image links. Ö 14:08, 7 March 2021 (UTC)[reply]

@Ö: I believe the first not going to happen again now, the second, hmm… looks like a problem. I'll review the related matching logic but it looks a bit tough to restrict the matches and keep felexibility. I'll try. Thanks! --grin ✎ 17:43, 7 March 2021 (UTC)[reply]
I have completely rewritten the replacement logic, hopefully it will not act weird from now on (fingers crossed). --grin ✎ 15:06, 8 March 2021 (UTC)[reply]
It looks like CommonsDelinker breaks now other types of links: [1] BR --Bicycle Tourer (talk) 05:00, 26 April 2021 (UTC)[reply]

Year problem?[edit]

I have seen some broken replacements of file names beginning with a year or a date: sv:Special:Diff/49214397, sv:Special:Diff/49081201, and sv:Special:Diff/49164988 (also in dewp in User:Bicycle Tourers comment above). In all these replacements both old and new file name begins with the same year. After the replacement the first digit has disappeared. In two replacements, both on sv and de wp, the file namespace is also missing. Ö 09:23, 9 May 2021 (UTC)[reply]

Here is another new example of a failed replacement: [2]. In this only the new filename starts with a year-number. It is from 2021-03-28, so happened clearly after the above mentioned rewriting of code (#Incorrect replacements). Interestingly the new filename is written correctly in the summary of this edit. BR --Bicycle Tourer (talk) 09:41, 9 May 2021 (UTC)[reply]
Similar issues: https://simple.wikipedia.org/w/index.php?title=2018_United_States_Senate_election_in_Texas&diff=7530838&oldid=7277120 Nunabas (talk) 18:52, 23 July 2021 (UTC)[reply]

Is it operating?[edit]

I see no edits in other wikis for 2 days though it edits here. I have also deleted some images that were used in ru.wiki, checked local contributions and still no edits there rubin16 (talk) 11:44, 6 June 2021 (UTC)[reply]

Pinging grin as operator of the crosswiki delinking task.   — Jeff G. ツ please ping or talk to me 12:50, 6 June 2021 (UTC)[reply]
Seems to be back rubin16 (talk) 20:09, 6 June 2021 (UTC)[reply]
Wasn't me! ;-) Maybe she was sleeping. Bots can be tired, too! :-] --grin ✎ 12:16, 7 June 2021 (UTC)[reply]
@Grin hello and sorry for disturbing. The bot seems to be down since yesterday. rubin16 (talk) 12:56, 2 February 2022 (UTC)[reply]
I will check it, thanks. grin ✎ 19:35, 5 February 2022 (UTC)[reply]
Someone have changed the bot password, or locked it. I never touched login, and I do not know whose email is in the account wnd what it is. I try to ask around, wish us luck. grin ✎ 19:50, 5 February 2022 (UTC)[reply]
It shall work again. It wasn't a global password but a local SUL-exempt one; the wiki have been blacklisted. (There is about a dozen wikis where Delinker doesn't have a working account, and doesn't handle it well.) It will be better now.
Feel free to ping me anytime the bot starts (not) behaving. Thanks! grin ✎ 21:41, 5 February 2022 (UTC)[reply]

Renaming strips file:-prefix from image links[edit]

See Revision of Commons:Village pump#Commons delinker mishandling links. Renaming File:2 Pallas.svg to File:2 Pallas-Sulfur.svg worked in Belarusian and Afrikaans, but broke the link by removing the (translated) prefix in Russian, Indonesian, Sundanese and turkish. In Vietnamese the prefix has a space and second half was removed.

See also #Incorrect replacements above for a similar example where the file name also started with a 2: [3]. MKFI (talk) 07:38, 3 October 2021 (UTC)[reply]

Happens on WP-en as well, and with 7 Iris, 8 Flora and 5 Astraea, not just a '2'.

Digit is stripped even when there is no 'file' prefix: [4]

It's not a problem if the rename removes the digit prefix, or adds one: only if it retains an existing single digit. It's not a problem if there is no space after the digit: [5] It is sometimes a problem with a 2-digit prefix: [6] -- incl. when there's no 'file' prefix: [7] [8]

But it doesn't always happen: [9] (see also File:10 Hygiea symbol original.svg)

Kwamikagami (talk) 17:41, 8 October 2021 (UTC)[reply]

This is interesting: this move was done through my acct, and it's correct. This similar move was done through the CommonsDelinker acct, and got messed up. Could it have anything to do with one having spaces and the other underscores? Also, I don't know why one would be in my acct and the other here: in both cases, I simply moved a file at Commons. Kwamikagami (talk) 01:47, 20 October 2021 (UTC)[reply]

{{Universal replace}} doesn't work[edit]

See https://bitbucket.org/magnusmanske/commons-delinquent/issues/82/universal-replace-doesnt-work Yann (talk) 21:40, 5 November 2021 (UTC)[reply]

How we will see unregistered users[edit]

Hi!

You get this message because you are an admin on a Wikimedia wiki.

When someone edits a Wikimedia wiki without being logged in today, we show their IP address. As you may already know, we will not be able to do this in the future. This is a decision by the Wikimedia Foundation Legal department, because norms and regulations for privacy online have changed.

Instead of the IP we will show a masked identity. You as an admin will still be able to access the IP. There will also be a new user right for those who need to see the full IPs of unregistered users to fight vandalism, harassment and spam without being admins. Patrollers will also see part of the IP even without this user right. We are also working on better tools to help.

If you have not seen it before, you can read more on Meta. If you want to make sure you don’t miss technical changes on the Wikimedia wikis, you can subscribe to the weekly technical newsletter.

We have two suggested ways this identity could work. We would appreciate your feedback on which way you think would work best for you and your wiki, now and in the future. You can let us know on the talk page. You can write in your language. The suggestions were posted in October and we will decide after 17 January.

Thank you. /Johan (WMF)

18:11, 4 January 2022 (UTC)

User talk:Nnh[edit]

User talk:Nnh has been listed at Commons:Deletion requests so that the community can discuss whether it should be kept or not. We would appreciate it if you could go to voice your opinion about this at its entry.

If you created this user page ⧼pageinfo-talkpage⧽, please note that the fact that it has been proposed for deletion does not necessarily mean that we do not value your kind contribution. It simply means that one person believes that there is some specific problem with it.

Please remember to respond to and – if appropriate – contradict the arguments supporting deletion. Arguments which focus on the nominator will not affect the result of the nomination. Thank you!
Afrikaans ∙ Bahasa Indonesia ∙ bosanski ∙ català ∙ čeština ∙ dansk ∙ Deutsch ∙ Deutsch (Sie-Form)‎ ∙ eesti ∙ English ∙ español ∙ Esperanto ∙ français ∙ galego ∙ hrvatski ∙ íslenska ∙ italiano ∙ magyar ∙ Nederlands ∙ norsk bokmål ∙ norsk nynorsk ∙ occitan ∙ Plattdüütsch ∙ polski ∙ português ∙ português do Brasil ∙ română ∙ shqip ∙ sicilianu ∙ slovenčina ∙ slovenščina ∙ suomi ∙ svenska ∙ Tiếng Việt ∙ Türkçe ∙ Zazaki ∙ Ελληνικά ∙ беларуская ∙ беларуская (тарашкевіца)‎ ∙ български ∙ македонски ∙ русский ∙ српски / srpski ∙ українська ∙ հայերեն ∙ বাংলা ∙ മലയാളം ∙ ပအိုဝ်ႏဘာႏသာႏ ∙ မြန်မာဘာသာ ∙ ไทย ∙ 조선말 ∙ 한국어 ∙ 日本語 ∙ 简体中文‎ ∙ 繁體中文‎ ∙ עברית ∙ العربية ∙ پښتو ∙ فارسی ∙ ދިވެހިބަސް ∙ +/−

Daraku K. (talk) 14:57, 24 January 2022 (UTC)[reply]

Deletion of link to deleted file from a discussion at Village Pump[edit]

@Grin: Hi, I just noticed a potential technical issue with how the bot operates. It has just removed two links to a deleted file from a discussion at the Village Pump.[10] One link was to generate the image and the other to provide a text link. When the discussion is archived, it will be unclear to future readers what we were talking about. It will also remove the "what links here" from the deleted file, so editors can't trace previous discussions from the deleted page. Is there a way to preserve the link without CommonsDelinker removing it again? From Hill To Shore (talk) 14:44, 6 February 2022 (UTC)[reply]

Just looking through the contributions of this account over the last few days and there appear to be a few odd edits. These ones break links in the featured picture candidates area, leaving half complete links and breaking discussions.[11][12] This edit removed an image from a gallery but also broke the preceding image by removing the file type.[13] This edit removed a link from a discussion in a help desk archive (which, like my previous comment, will make the help discussion harder to understand and removes the ability to find the discussion from the what links here command on the deleted file).[14] This link removed the link from the Media of the Day template of 26 June 2019; surely we would want to preserve the fact that a promoted file has since been deleted?[15] All of these edits are slightly concerning to me. Do they normally pop up or has someone become a little over zealous in executing the bot commands recently? As a minimum, I would expect the Village Pump, Help Desk and similar discussion forums to be excluded from automatic link removal. From Hill To Shore (talk) 15:07, 6 February 2022 (UTC)[reply]
Most of your examples are not errors: the images were deleted and the bot have been requested to remove their references.
I understand that you would like to ask for some pages to be protected but I haven't written the bot code, nor do I plan to make development on it. I keep it running and I try to fix any bugs (errors), but I will rather not implement new logic, at least not without strong community support. Right now the bot skips (un)deletion_requests pages and anything containing "Bot", but no other exceptions are present. If you ask around and collect a list of pages, then succeed to ask the community to vote on it (preferably with no less than a dozen votes) then I would get the time to implement it, but please, keep the list short, if possible, and well reasoned.
As for special cases like templates... it rarely happens that a templated image gets deleted. I'd say it's easier to revert the occasional change. If it starts to occur frequently then remind me to do something about it. grin ✎ 16:49, 6 February 2022 (UTC)[reply]
It is not clear what you wanted to request. You suggest that the bot should ignore commons:Village Pump? grin ✎ 16:37, 6 February 2022 (UTC)[reply]
I was asking if this was normal bot behaviour or if something had gone wrong on the identified occassions. If this is how it is meant to work, I will start a separate discussion as you suggest to check for the community's view. Thanks for the reply. From Hill To Shore (talk) 17:09, 6 February 2022 (UTC)[reply]
As far as I see this is normal work, and it always have been working this way. I believe it's not hard to put in pages to skip, but I'd prefer multiple voices to support that. (I probably would support as well, seems logical.) grin ✎ 21:49, 7 February 2022 (UTC)[reply]

False positives leading to a broken page (templates plus File: prefix)[edit]

@Grin: If you check this diff you'll see CommonsDelinker removing the link to a page that features the filename in its name, with fairly catastrophic results. Since "/" never comes before files in any valid transclusion of the file, I'd say not doing delinkings where the string "/[File|Image|etc]:Foo.bar" exist should remove these cases. I wouldn't imagine this sort of thing would appear much outside of subpages of Feature picture processes, so that's a possible way to narrow the check. Adam Cuerden (talk) 07:22, 17 March 2022 (UTC) @Grin: I should probably mention that, similar to Commons featured picture candidates, a common format for en-wiki FPCs is "Wikipedia:Featured picture candidates/File:Foo.jpg" - and the bot picked up on the last bit of that, which turned it into "Wikipedia:Featured picture candidates/" - which is a redirect to "Wikipedia:Featured picture candidates" and hence transcluded the entirety of en:Wikipedia:Featured picture candidates. Adam Cuerden (talk) 08:37, 17 March 2022 (UTC)[reply]

Ouch. I'll try to massage the patterns a little if possible, but I have a bad feeling that there were no easy way to prevent this from happening. Let me check (in the following days). grin ✎ 19:14, 17 March 2022 (UTC)[reply]
On the upside, I don't think it's a particularly common issue, just one I thought I should mention since I stumbled on it. If it helps, the way I found it was noticing it in the list of pages including a redirect I was trying to delete (I made a typo in a Featured picture candidate nomination, Frances for Francis) and looking to see why. If this issue had come up before in featured pictures, it probably would have also shown up from that (depending on how often Wikipedia updates pages, anyway). Adam Cuerden (talk) 20:20, 17 March 2022 (UTC)[reply]
Found a better proxy: Check the en-wiki uses of File:Colortest.png - an image used in the header of Featured picture candidates - and it's clear that there can't be any other page that CommonsDelinker damaged (and hasn't been fixed) in that system of pages, at least. Which isn't terrible. Adam Cuerden (talk) 20:43, 17 March 2022 (UTC)[reply]
Okay, so the problem is that the original link was buggy: it should not have contained File: so Delinker would have left it alone. The normal form is {{featured/badimage.jpg}} and not {{featured/File:badimage.jpg}}, and only the latter (improper form) gets massacred. These needed manual fix anyway, so delinker doesn't make it much worse. ;-) (And fixin this would require lot of regular expressions with negative lookbehinds and I don't quite feel like debugging them for this rather negligible use case.)
Do you think there's any need to investigate this further, or can we close this with "these need manual intervention anyway"? :-) grin ✎ 15:31, 18 March 2022 (UTC)[reply]
As far as I'm aware, including File: has always been normal, and the lack of it much rarer. COM:Featured picture candidates/candidate list uses that as required format, for instance. (But Commons:Featured_picture_candidates/ doesn't exist, eliminating the issue to some extent. [https://commons.wikimedia.org/w/index.php?title=Special:WhatLinksHere/Commons:Featured_picture_candidates/&limit=500 is the aftermath there.
I don't think it's a huge issue, all told. It's mildly damaging some archives No one really cares about, at worst. Adam Cuerden (talk) 18:25, 18 March 2022 (UTC)[reply]

A bad edit in a gallery[edit]

Hello,
I think that this edit is an error... @Grin: is it a known bug of the bot?
Regards --NicoScribe (talk) 17:19, 27 March 2022 (UTC)[reply]

Huh, that looks weird. It's visibly choking on gallery comments, but I haven't seen such one before. I'll check. Thanks! grin ✎ 19:08, 27 March 2022 (UTC)[reply]

Edit undone[edit]

@Grin: , this edit had to be partially undo. The removal of the image that its summary stated was fine. It was the unstated part of the edit, the change of the image discription for another image, that is the problem.

  1. Its a picture of a Russian coin, not something on display in Genoa
  2. The formatting of the image tag caused the page to register as a Lint error (bogus file options).

--Creol(talk) 18:46, 28 March 2022 (UTC)[reply]

File extension in galleries[edit]

In sv:Special:Diff/50347356 and sv:Special:Diff/50256218 on Swedish Wikipedia deleted images were removed from galleries. For some reason the bot also removed the file extension ("jpg" and "JPG") of the images on the previous lines. That created broken image links for files that still exists in Wikimedia Commons. Ö 15:17, 6 April 2022 (UTC)[reply]

@Grin: This also happened here in this edit.   — Jeff G. ツ please ping or talk to me 22:04, 11 April 2022 (UTC)[reply]
It seems that the bot doesn't like galleries. :-( I'll check. Thanks. grin ✎ 15:24, 12 April 2022 (UTC)[reply]
@Jeff G. @NicoScribe @Creol I have reworked the internals (regexp matches) of the bot, and it seems that it magically fixed all the aforementioned problems at once. In the same swoop I also migrated it to the new toolforge k8s framework, and I wanted to create a repo to make it more visible but I'm sleeping now (php kicks out my brain cells one by one). If the bot misbehaves please tell me, though I have tried to thoroughly testing the regexps with various weird media:syntaxen.
Oh, by the way... did you know, that you can pour spaces all over into image links, like [[ : File  : example.jpg | 200px | caption ]], and even wilder in galleries? I believe the bot handles most of these monsters as well now, but tries not to be too smart (like vandalising templates with unknown structure). I hope it will do its job just fine. If not, ping me again.
Thanks for keeping an eye on him (her?) and telling me if anything's wrong! grin ✎ 21:47, 12 April 2022 (UTC)[reply]
Thank you @Grin:
Do you plan to correct the other bad edits? The first one that I have found is this edit from 23 January 2022. If you look at CommonsDelinker's contributions restricted to the Gallery namespace, you can find many bad edits between 23 January 2022 and 12 April 2022. --NicoScribe (talk) 16:16, 14 April 2022 (UTC)[reply]
I am not sure what you asking for. I believe I have fixed the problem causing what you quote, it means that if you observe it after it has been fixed I have to look at it again. I cannot fix a bug 4 months in the past.
If you see a problem (in the past) you can fix it. The one you have quoted I have fixed for you. grin ✎ 23:04, 14 April 2022 (UTC)[reply]
@Grin: I thank you again for your correction of the bot, done on 12 April 2022. Since then, CommonsDelinker has made 2 contributions in the Gallery namespace, both OK. That's perfect!
Now, please look at CommonsDelinker's contributions restricted to the Gallery namespace between 23 January 2022 and 12 April 2022, and you will easily find many many many bad edits. What I am asking for is: who will correct them? Do you plan to write a script to correct them, or do you plan to correct them manually, or do you expect other users to correct them? --NicoScribe (talk) 14:35, 15 April 2022 (UTC)[reply]
People have been corrected the reported problems so far and I hope they will continue to do so in case they happen. I only need the diff, there is no need to keep any mistakes in active articles.
Automagically reverting would be probably a bad idea, even if I had the time (which I don't); most of the problematic edits were fixed within minutes and writing a script for the others would require way more time than fixing/reverting them manually. I'd appreciate if anyone see any of those would fix them as I can't responsibly say I have a simple method to do it. Thank you! grin ✎ 22:28, 15 April 2022 (UTC)[reply]

@Grin: I have 7 remarks:

  1. Yesterday I have spent several hours checking the 283 edits done in the Gallery namespace between 23 January 2022 and 12 April 2022, and I have corrected manually the 98 pages containing one bad edit (or several bad edits).
  2. You can't expect other users to find/fix the bad edits. Among the 283 edits that I have checked, no one (except you and me) had quickly found and fixed a bad edit.
  3. The <gallery> tags are not limited to the Gallery namespace: they can be used in the other namespaces. Who will correct the hundreds or thousands of bad edits in these namespaces?
  4. The <gallery> tags are not limited to the Commons project: they can be used in several hundreds Wikimedia projects. Who will correct the hundreds or thousands of bad edits in these projects?
  5. You said "most of the problematic edits were fixed within minutes and writing a script for the others would require way more time than fixing/reverting them manually". The problem is not the time to correct one bad edit (this time is short), the problem is the time to correct hundreds or thousands of bad edits. So, writing a script for hundreds or thousands of bad edits would not require more time than fixing them manually. Writing a script is also necessary to find the bad edits, because the bot made several thousands edits and only a part of them is bad. I am not saying that writing a script is easy, I am saying that is is necessary.
  6. I hope that you will find when the bug was inserted in the bot's code. If it was inserted just before 23 January 2022, then the bad edits are limited to the period between 23 January 2022 and 12 April 2022. If it was inserted long before 23 January 2022, then the problematic period is longer.
  7. I have seen another thing in several edits, like this one: the file is removed but the associated description is not removed. But I don't know whether you consider such edits good or bad, so I have not corrected these ones.

--NicoScribe (talk) 08:00, 17 April 2022 (UTC)[reply]

1. Thank you for your help!!
2. I don't expect anyone doing anything. I hope people do fix mistakes when they see it; and I hope they report them if they notice them.
3+4. From the perspective of the bot there is no "gallery" (namespace or else). It replaces (or removes) the files from direct links, direct includes, template args and separate lines (that one would be most of the galleries). It tries not to remove them from template paths or other uncontrolled occurences.
5. I don't quite see what data have you used to calculate the time required for the creation of such a script but I can assure you that some of your assuptions must be incorrect. I will try to create such a script, but it requires to find a modern working library of the language I use (which is not php), then to conjure an algorithm to find which edits were bad (which is not as simple as it looks, but possibly doable), then it needs to be written (and I usually do not have multiple hours in one slot to spend on wikipedia, it will take considerate amount of time), then it needs to be tested (since it would, as you estimate, do a lot of unattended edits), then it could be let to do the fixing. I will do start creating such a script, and I hope it will be ready sooner than later. No promises on any deadlines though.
6. The bug always have been there and you may have heard that the bot has been written decades ago, and repeatedly left alone by its maintainer and someone picked up where the ancestors have left; the last of this chain is myself, sine the bot has been broken for months and I had the power to help, so I did. So I maintain the code and I try to touch it as little as possible since every change would need extensive testing. Also I haven't done an audit of the code, nor had proven any of its correctness, so if it was broken before it have stayed broken unless someone noticed the problem, told me and then I can fix it. Of course the alternative approach could be a complete rewrite, probably using some better language than it's written in now, but a rewrite would require massive amounts of volunteer time which I cannot offer at the moment.
7. Since multiple small bugs have been fixed since 2018 this one was possibly fixed in due time. At least my current testing framework contains such a pattern and it looks fine; so my guess is that this one has been fixed.
I try to create some rudimentary test framework to check correctness, at least I have formed the intent now. Let's hope it realises soon. ;-)
I see that this is not a perfect solution, but the bot is extremely useful and the demand to keep it alive is very high, so I try to keep it in working order instead of giving up. Any and all of the help is appreciated by both me and the rest of the community. grin ✎ 19:44, 17 April 2022 (UTC)[reply]
@Grin:
2. One additional remark here: for people (as opposed to a script) it will be easy to fix some bad edits (example) but harder for other bad edits (example).
5. Thank you very much. Well, yesterday I have spent 3 hours for only 283 edits. Let's say that a guy wants to check manually all CommonsDelinker's contributions between January and April 2022: according to Wikiscan, CommonsDelinker has made 40644 edits to its 4 biggest projects for this period (15282 edits to en.wp, 11606 to Commons, 8772 to es.wp, 4984 to fr.wp). If this guy is working at my speed he would need more than 430 hours only to cover these 4 projects.
6. You said "The bug always have been there": well, OK, but I have not seen it in the edits before 23 January 2022.
7. You said "Since multiple small bugs have been fixed since 2018 this one was possibly fixed in due time": well, this bug was still present on 9 April 2022 (example) so I suppose that it is your fix done on 12 April 2022 which also correct this bug.
Thank you again, I hope that you will find the time to work on the script (because in the meantime there are hundreds or thousands of bad edits which remain in several projects). --NicoScribe (talk) 22:09, 17 April 2022 (UTC)[reply]
@Grin: Thank you for all your hard work.   — Jeff G. ツ please ping or talk to me 23:41, 7 May 2022 (UTC)[reply]

Removed image name rather than renaming[edit]

@Grin: , hello in this edit the file name was removed rather than replaced by the renamed image. Keith D (talk) 17:49, 3 May 2022 (UTC)[reply]

That was not nice of her. I will check in the afternoon, until then she's grounded. grin ✎ 09:14, 4 May 2022 (UTC)[reply]
@Grin: so problem was in ru-wiki on May 2: for example, edit edit --Proeksad (talk) 10:52, 6 May 2022 (UTC)[reply]
Thank you, I already fixed the problem and now I'm working on the cleanup script. If someone have changed the page after delinker it will not be touched though (at least not soon, since I'm not sure the bot could do undo cleanly). grin ✎ 18:26, 6 May 2022 (UTC)[reply]
The main reverting round has been done by grinBot, I'll review the rest and the ones mentioned above by NicoScribe (they need to be reviewed by another script). grin ✎ 09:16, 8 May 2022 (UTC)[reply]

Bot stopped?[edit]

@Grin: Since May 10th, bot seems not to work in any wikis and delinker result page isn't updated. Any problems? Regards, --Netora (talk) 13:20, 16 May 2022 (UTC)[reply]

Oh no! Yes, problem. No, it was not suspended but outright killed by git. I degitted it and it should run again, thank you very much for the notification. grin ✎ 16:01, 16 May 2022 (UTC)[reply]
@Grin hello. It seems that bot isn't updating User:CommonsDelinker/commands since July 10, the same with the log on toolforge rubin16 (talk) 13:28, 13 July 2022 (UTC)[reply]
Indeed, it was dying on https://shn.wiktionary.org/ this time, plus it caused an irregular database entry which unfortunately blocked the bot from completing the pending jobs. It shall be fixed now; first she process the pending jobs then start to gather new ones [soon-ish]. Thanks for the notification! grin ✎ 22:30, 17 July 2022 (UTC)[reply]
@Grin pinging again as it seems that the delinker bot stopped working again rubin16 (talk) 07:57, 27 September 2022 (UTC)[reply]
Indeed. I have been fighting with WMF's "keep jobs alive" feature not keeping the jobs alive. I probably have to create a fature to keep alive the WMF feature to keep the bot alive... /rolling eyes/
Thanks for the report, I've (re)started it. grin ✎ 11:14, 30 September 2022 (UTC)[reply]

Memory explosion[edit]

Just a sidenote that I had to change the code to limit the maximum number of replaces due to File:CC-BY icon.svg which had (much) more than 65000 instances; the bot have rejected it now to be able to run without being killed by Toolforge oomkiller, but I'll see whether this part of the code could be rewritten in a less obtrusive manner. Soon-ish, until then such requests will be rejected. --grin ✎ 21:40, 19 May 2022 (UTC)[reply]

Retrieved from "https://commons.wikimedia.org/w/index.php?title=User_talk:CommonsDelinker/archive01&oldid=726750273"