MediaWiki talk:Gadget-Stockphoto.js/Closed tickets

Small issues October 2010

• Option to turn off see above --Magnus Manske (talk) 14:46, 5 October 2010 (UTC)
• Do not show on pages with deletion templates
  • Fixed by Krinkle TheDJ (talk) 18:41, 8 October 2010 (UTC)
• Fix SVG and OGG
  • Caused by broken StockPhoto.file_url lookup (mwEmbed influence). should probably use a from .fullMedia
• Links do not work with MwEmbed gadget - example. LeinaD dyskusja 10:55, 7 October 2010 (UTC)
  • Yes, already listed under the Ogg issue. TheDJ (talk) 18:42, 7 October 2010 (UTC)
    • Fixed TheDJ (talk) 18:41, 8 October 2010 (UTC)
• i18n (translations) done --Magnus Manske (talk) 14:46, 5 October 2010 (UTC)
• The script fails when viewing a diff (example)

   Fixed –Krinkle^talk 18:08, 4 October 2010 (UTC)

• enable on Monobook skin
  • Now imports jQuery UI, so that should be a possibility.Done --Magnus Manske (talk) 19:16, 5 October 2010 (UTC)
• Prefer the attribution line (if any) instead of building it from the various fields. Example done --Magnus Manske (talk) 15:45, 5 October 2010 (UTC)
• link error when using smaller file versions. It links to some random other file. See printscreen here. Amada44  ^{talk to me} 16:26, 5 October 2010 (UTC)
  • Had you visited that other file in the past Amanda ? TheDJ (talk) 16:37, 5 October 2010 (UTC)
    • not directly, but it is media of the day and so the browers must have seen it. Now I have an different image I had visited when I click on the other sizes. btw. Firefox 3.6.10 on OS X 10.6.4. Amada44  ^{talk to me} 16:42, 5 October 2010 (UTC)

       Fixed --Magnus Manske (talk) 19:41, 5 October 2010 (UTC)

• In both of the "Use this file" links, remove reference to "from Wikimedia Commons". That is not required for attribution. 99of9 (talk) 05:12, 7 October 2010 (UTC)
  • It is not required, but it is short and great PR for the project :-) --Magnus Manske (talk) 14:42, 7 October 2010 (UTC)
• When the drop down arrow (next to the star to make an image your favourite) is directly above the new buttons (resize the width of your browser to replicate this), the descending menu goes underneath the buttons, meaning the drop down menu items cannot be used (e.g. tineye). 99of9 (talk) 05:12, 7 October 2010 (UTC)
  • This is due to the raised z-index. Why are we using that ? As far as I know, only IE 5.5 might require that, and IE 5.5 is no longer supported in our JS tools. TheDJ (talk) 18:42, 7 October 2010 (UTC)
    • Fixed. A working dropdown is more important thant a possible IE5 bug--DieBuche (talk) 19:49, 7 October 2010 (UTC)
• Add social media share links (See also en:Wikipedia:Signpost/Template:Signpost-article-start and wikinews:en:Template:Social_bookmarks ) done --Magnus Manske (talk) 14:46, 5 October 2010 (UTC)

Opera sucks

• On Opera 9.27 for Mac with the Classic skin, the "use this file" links overlap the image.
• On Opera 9.27 for Mac with the Classic skin, the "File URL" field is always "/wiki/Main_Page"
• On Opera 9.27 for Mac with the Classic skin, the "attribution" field is badly broken. For example, "Use this file on the web" for File:SpokaneFromPalisades 20070614.jpg gives

Main Page | Recent changes | Edit this page | Page historyPrintable version | Disclaimers | Privacy policy | SpokaneFromPalisades_20070614.jpg Carnildo (Talk)Log out | Preferences | Help   47° 39' 14.36" N, 117° 29' 10.42" W This and other images at their locations on: Google Maps - Google Earth - OpenStreetMap(Info)47.653988;-117.486227This file is licensed under the Creative Commons Attribution 2.5 Generic license.18:49, 15 June 20073,006×888 (887 KB)Carnildo (talk | contribs) ({{Information |Description=Downtown Spokane, Washington, as viewed from Palisades Park to the west of the city. |Source=Own work |Date=June 14, 2007 |Author=Mark Wagner |Permission=Creative Commons Attribution |other_versions= }} == Licensing == {{cc-by-)PENTAX Corporation PENTAX K100D 1/750 sec (0.0013333333333333)f/1140017:38, 14 June 2007150 mm3,006888Normal72 dpi72 dpidigiKam-0.9.117:38, 14 June 20072Normal program2.2117:38, 14 June 20070PatternFlash did not fire, compulsory flash suppressionsRGBOne-chip color area sensorNormal processAuto exposureAuto white balance225StandardNormalNormalNormalDistant viewEdit this page | Stop watching | Discuss this page | Page history | What links here | Related changes  | Main Page | About Wikimedia Commons | Recent changes |   This page was last modified on 25 March 2010, at 20:28. Text is available under the Creative Commons Attribution/Share-Alike License; additional terms may apply. See Terms of Use for details. [CC-BY-2.5], from Wikimedia Commons

--Carnildo (talk) 20:32, 7 October 2010 (UTC)

• On Opera 9.27 for Mac using the Classic skin, the "full resolution" link on the "download this file" option is broken, being "http://commons.wikimedia.org/wiki/Main_Page" for any image. The links for downscaled versions are correct. --Carnildo (talk) 20:34, 7 October 2010 (UTC)
• On Opera 9.27 for Mac using the Classic skin, the "BBCode" and the resolution selector boxes in the "use this file on the web" form do nothing. --Carnildo (talk) 20:37, 7 October 2010 (UTC)

• • For now, gadget only enabled on Vector and Monobook, since those are the only supported skins. Disabled entire gadget under opera, because it is badly supported by jquery. TheDJ (talk) 23:58, 7 October 2010 (UTC)
    • Especially 9.27 is known for it's jquery problems, everything seems to work for later versions--DieBuche (talk) 15:42, 18 October 2010 (UTC)

• In the html path for "Use this on a website", link the license initials to the actual license. 99of9 (talk) 05:12, 7 October 2010 (UTC)
  • OK. Where do I find a comprehensive, machine-readable list of all our license category names with matching URL? --Magnus Manske (talk) 14:42, 7 October 2010 (UTC)
    • Doesn't exist as far as I know. Our license templates were never designed with these kinds of things in mind. (Major oversight if you ask me). I suggest we rework the licenses to provide this information inside classed html. We should start by defining classes for the licenses, as we have for the Information templates. TheDJ (talk) 18:42, 7 October 2010 (UTC)
      • I have made suggestions on how to standardize how license templates provide this type of information. TheDJ (talk) 13:28, 11 October 2010 (UTC)
        • Implemented--DieBuche (talk) 15:42, 18 October 2010 (UTC)

• The logged-out version (big icons on the right side) does not work as expected in RTL languages (Arabic, hebrew etc). The The text links move to the left of the icons, but the whole set does not move to the left dice of the image, they just stay in their place. See here for example (after you log out). -- Orionist ★ talk 02:06, 9 October 2010 (UTC)
  • Disabled on RTL versions, until fixed. TheDJ (talk) 12:39, 9 October 2010 (UTC)
    • Fixed--DieBuche (talk) 15:42, 18 October 2010 (UTC)

• Migrated licenses such as {{GFDL|migration=relicense}} and {{GFDL|Cc-by-sa-3.0-migrated}} show only as GFDL in the Attribution field. They should also show the CC. -- Orionist ★ talk 15:55, 17 October 2010 (UTC)
  • done--DieBuche (talk) 15:42, 18 October 2010 (UTC)

• links to the license texts have to be included to comply with CC fixed, to some degree --Magnus Manske (talk) 14:46, 5 October 2010 (UTC)
  • See above--DieBuche (talk) 15:42, 18 October 2010 (UTC)

• See #Author info below: if there are {{Creator}} templates, the whole template is included in the author info. Lupo 08:31, 18 October 2010 (UTC)
  • Done before the report, maybe you have an old version cached--DieBuche (talk) 15:42, 18 October 2010 (UTC)

• 

  Layout bug in Safari on MAC OS X

  Layout bug in Safari on Mac OS X (not logged in). Seems to be some strange interaction with ImageAnnotator. Problem disappears after a reload; re-appears after a shift-reload. Lupo 08:31, 18 October 2010 (UTC)
  • The same in Google Chrome (sometimes). LeinaD dyskusja 14:44, 18 October 2010 (UTC)
    • The culprit seems to be the width calculation on lines 121-129, needed because of the center alignment of the texts. This width calculation yields a maxW that spans the whole width of the window (1676px in my window), which appears logical since div#stockphoto_base is positioned absolutely and the icon div and its corresponding text div at that point are, in Safari, not yet aligned horizontally but vertically (the icon divs, BTW, are still empty, since the images haven't been loaded yet). I suggest simply deleting lines 121-129 (i.e., not hardcoding text div widths) and left aligning the text instead. Lupo 15:31, 18 October 2010 (UTC)
      • Oh, and it doesn't seem to be a direct interaction problem with ImageAnnotator, though the fact that IA changes the div#file into a left-float may contribute to the subsequent layout problems under Webkit. Lupo 15:35, 18 October 2010 (UTC)
    • I think I got a fix--DieBuche (talk) 15:42, 18 October 2010 (UTC)
      • Should be fixed. I removed other hardcoded styles as well.--DieBuche (talk) 17:05, 18 October 2010 (UTC)

• Not work on Monobook. LeinaD dyskusja 10:23, 16 October 2010 (UTC)
  • Not enabled there--DieBuche (talk) 16:04, 28 October 2010 (UTC)

• I suggest replacing the [x] button with a [+]/[-] button at least in the logged-out version. Since reenabling the feature requires navigating through the browser options to find and delete the right cookie. And most people don't know how to do that. -- Orionist ★ talk 02:13, 9 October 2010 (UTC)
  • Done--DieBuche (talk) 16:04, 28 October 2010 (UTC)