Commons:Featured picture candidates/File:Jamides bochus 2 by kadavoor.jpg

From Wikimedia Commons, the free media repository
Jump to navigation Jump to search

File:Jamides bochus 2 by kadavoor.jpg, not featured[edit]

Voting period is over. Please don't add any new votes.Voting period ends on 28 Nov 2013 at 10:41:31 (UTC)
Visit the nomination page to add or modify image notes.

A test nomination to check the working of Nsfw template. NSFWTAG
Yes; now it is working! Thank God (and you too). JKadavoor Jee 11:33, 19 November 2013 (UTC)[reply]
Hmm. It isn't working for me. I can see the HTML has the required element now but I don't get the butterfly hidden. The source for the gadget is MediaWiki:Gadget-DeferredDisplay.js. -- Colin (talk) 11:42, 19 November 2013 (UTC)[reply]
I see the problem, the code is testing for the page == "Commons:Featured_picture_candidates". It only works for that page. It needs to work for the "Commons:Featured_picture_candidates/candidate list" page too, as well as the actual candidate page. Really anything beginning with "Commons:Featured_picture_candidate". Also it doesn't interact well with the Beta Media Viewer as clicking launches the media viewer overlay rather than uncovers the image in-place. Also the image does appear briefly before being covered up. So I think the implementation of this gadget is not quite ready. -- Colin (talk) 11:46, 19 November 2013 (UTC)[reply]
It is working for me with and without "beta features" enabled, although some unfriendliness with media viewer as you said. Currently it is working only on the main FPC page; not in individual review page. So we have to see it if any plan to comment. Do we need it there too? Anyway Dschwen will hopefully look into it. JKadavoor Jee 11:52, 19 November 2013 (UTC)[reply]
With the beta, I can't get the image uncovered. It remains with the warning symbol, though the image overlay feature of the beta works. So I think there are a few bugs.
  • Fix gadget so it tests if url contains "Featured_picture_candidate", this would pick up the FPC talk pages as well as sub pages where the nominations live.
  • Fix nsfw template so it works on images that aren't thumbs or in galleries.
  • Fix gadget so the image doesn't briefly appear.
  • Improve interaction with beta media viewer. Perhaps rather than display an image at all, we just need a box with text and some links.
  • Change replacement warning icon so that it is clear why the image is covered up. I favour some text like "This image has been hidden by the Deferred Display gadget since it is tagged NSFW. Click to display." -- Colin (talk) 12:51, 19 November 2013 (UTC)[reply]
Gallery tags removed; hope Dschwen will check here. JKadavoor Jee 16:49, 19 November 2013 (UTC)[reply]
It works well for me, with IE 11 and FF 25.0.1. And "thanks" to Jkadavoor, he was now my censor ... grrrr  ;-) --Alchemist-hp (talk) 21:20, 19 November 2013 (UTC)[reply]
:) JKadavoor Jee 03:13, 20 November 2013 (UTC)[reply]
  • Some may be aware I have prepared an actual NSFW nomination; however, I will wait a bit longer until we are certain this gadget works as intended (it appears to work with the transcluded page too now). Perhaps a discussion on the talk page regarding a guideline when to use and a warning at the top of this page (recommended to me by Colin) is warranted too. Saffron Blaze (talk) 22:25, 19 November 2013 (UTC)[reply]
  • Now it is working fine for me in my Chrome 31.0.1650.57 m too; everything as desired, hiding again when the page refreshed. Thanks Dschwen. Saffron, we can expand the documentation and guidelines, but it seems ready to test you nomination, now. :) (I will be away for a week; so feel free to remove this nomination, when the testing is over. Have an eye on the FPCBot too; especially on the log page.) JKadavoor Jee 03:13, 20 November 2013 (UTC)[reply]
Confirmed results:
Result: 0 support, 0 oppose, 0 neutral → not featured. /A.Savin 00:20, 25 November 2013 (UTC)[reply]